Skip to content

Conversation

@beniwohli
Copy link
Contributor

What does this pull request do?

While the previous snippet wasn't necessarily bad, it used
uuid4 for something it isn't intended to. Python 3 provides
a cryptographically secure token generator, so let's tell
our users to use that instead.

While the previous snippet wasn't necessarily bad, it used
uuid4 for something it isn't intended to. Python 3 provides
a cryptographically secure token generator, so let's tell
our users to use that instead.
@ghost
Copy link

ghost commented Jun 21, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-21T07:07:43.340+0000

  • Duration: 3 min 8 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@beniwohli beniwohli merged commit dcf83da into elastic:main Jun 22, 2022
@beniwohli beniwohli deleted the better-secret-token-generator-code branch June 22, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants