Skip to content

make sure to close client in django fixtures #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

make sure to close client in django fixtures #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/contrib/django/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ def django_elasticapm_client(request):
instrument(client)
app.client = client
yield client
client.close()

app.client = old_client

Expand All @@ -53,6 +54,7 @@ def django_sending_elasticapm_client(request, validating_httpserver):
app.client = client
client.httpserver = validating_httpserver
yield client
client.close()

app.client = old_client

Expand Down
2 changes: 1 addition & 1 deletion tests/requirements/requirements-base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ statistics==1.0.3.5
urllib3
certifi
Jinja2
Logbook
Logbook==1.3.0
MarkupSafe
WebOb
Werkzeug
Expand Down