security: add permissions block to workflows #1972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
previously approved these changes
Feb 21, 2024
v1v
reviewed
Feb 21, 2024
v1v
reviewed
Feb 22, 2024
v1v
reviewed
Feb 22, 2024
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
|
The is a draft PR reworking the labeler workflow that is adding correct permissions too #2003 |
reakaleek
commented
Mar 12, 2024
v1v
previously approved these changes
Mar 12, 2024
reakaleek
commented
Mar 14, 2024
This will be removed in another PR
xrmx
approved these changes
Mar 14, 2024
xrmx
pushed a commit
that referenced
this pull request
Mar 20, 2024
* security: add permissions block to workflows * Update .github/workflows/test-reporter.yml Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com> * Update .github/workflows/labeler.yml * Remove permissions This will be removed in another PR --------- Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We want to set the default permissions for workflows to read-only for contents.
This is a security measure to prevent accidental changes to the repository.
This change adds a top-level permissions block to all workflows in the .github/workflows directory.
In some cases workflows might need more permissions than just
contents: read.Please checkout this branch and add the necessary permissions to the workflows.
If your workflow uses a Personal Access Token (PAT), we can still add the permissions block,
but it will not have any effect.
Merging this PR as is might cause workflows that need more permissions to fail.
If there are any questions, please reach out to the @elastic/observablt-ci