Deprecate Python < 3.2 logging code and and remove documentation #1984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we don't support Python < 3.6 there's not reason to keep code for Python versions older than that.
github-actions
bot
added
agent-python
community
basepi
previously approved these changes
Mar 4, 2024
Co-authored-by: Colton Myers <colton@basepi.net>
trentm
approved these changes
Mar 13, 2024
xrmx
added a commit
that referenced
this pull request
Mar 20, 2024
* docs: remove Python < 3.2 specific documentation * handlers/logging: deprecate Python<3.2 LoggingFilter Since we don't support Python < 3.6 there's not reason to keep code for Python versions older than that. * Update elasticapm/handlers/logging.py Co-authored-by: Colton Myers <colton@basepi.net> --------- Co-authored-by: Colton Myers <colton@basepi.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Remove specific documentation for Python < 3.2 and deprecate the old code to be removed on next major version.
Related issues
None