Skip to content

Conversation

@bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 requested review from a team and thaddeuselastic March 18, 2024 18:54
@trentm trentm merged commit adff59c into main Mar 18, 2024
@trentm trentm deleted the bmorelli25-patch-1 branch March 18, 2024 23:19
@xrmx
Copy link
Member

xrmx commented Mar 19, 2024

It'll probably be better to test against flask 3.0 if we are going to link to 3.0 docs 😅

@trentm
Copy link
Member

trentm commented Mar 19, 2024

Doh! And here I thought this was the safest possible thing I could actually merge in this repo. :)

@trentm
Copy link
Member

trentm commented Mar 19, 2024

@xrmx Should this perhaps change to https://flask.palletsprojects.com/en/2.3.x/quickstart/#debug-mode then?

@xrmx
Copy link
Member

xrmx commented Mar 19, 2024

@trentm don't worry, I'll add flask 3.0 to test matrix later this week. AFAIR there were no issues on OTel land

xrmx pushed a commit that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants