github-actions: replace third-party actions #2257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
commented
Apr 1, 2025
kruskall
approved these changes
Apr 1, 2025
xrmx
approved these changes
Apr 2, 2025
xrmx
reviewed
Apr 4, 2025
| uses: actions-ecosystem/action-add-labels@v1 | ||
| with: | ||
| labels: agent-python | ||
| run: gh issue edit "$NUMBER" --add-label "agent-python" |
There was a problem hiding this comment.
@v1v This is not working, NUMBER is empty when I am opening a PR :). See https://github.com/elastic/apm-agent-python/actions/runs/14264122101/job/39982015773?pr=2261
v1v
commented
Apr 4, 2025
| triage: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| NUMBER: ${{ github.event.issue.number }} |
There was a problem hiding this comment.
Should be github.event.issue.number || github.event.pull_request.number or something along those lines. I'll review exactly the correct context field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Use
ghcli to add labelsUse our pre-commit composite action: https://github.com/elastic/oblt-actions/tree/main/pre-commit
Related issues
See #2254 (comment)