-
Notifications
You must be signed in to change notification settings - Fork 232
github-actions: replace third-party actions #2257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,9 @@ permissions: | |
jobs: | ||
triage: | ||
runs-on: ubuntu-latest | ||
env: | ||
NUMBER: ${{ github.event.issue.number }} | ||
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
steps: | ||
- name: Get token | ||
id: get_token | ||
|
@@ -26,9 +29,7 @@ jobs: | |
"members": "read" | ||
} | ||
- name: Add agent-python label | ||
uses: actions-ecosystem/action-add-labels@v1 | ||
with: | ||
labels: agent-python | ||
run: gh issue edit "$NUMBER" --add-label "agent-python" | ||
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @v1v This is not working, NUMBER is empty when I am opening a PR :). See https://github.com/elastic/apm-agent-python/actions/runs/14264122101/job/39982015773?pr=2261 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Uhm, I'll review it |
||
- id: is_elastic_member | ||
uses: elastic/oblt-actions/github/is-member-of@v1 | ||
with: | ||
|
@@ -37,8 +38,4 @@ jobs: | |
github-token: ${{ steps.get_token.outputs.token }} | ||
- name: Add community and triage labels | ||
if: contains(steps.is_elastic_member.outputs.result, 'false') && github.actor != 'dependabot[bot]' && github.actor != 'elastic-observability-automation[bot]' | ||
uses: actions-ecosystem/action-add-labels@v1 | ||
with: | ||
labels: | | ||
community | ||
triage | ||
run: gh issue edit "$NUMBER" --add-label "community,triage" | ||
v1v marked this conversation as resolved.
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be
github.event.issue.number || github.event.pull_request.number
or something along those lines. I'll review exactly the correct context field