try to fix flaky appveyor tests #259
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_urllib3 is quite flaky on appveyor. The assumption is that due to the slow executor machine, the http server used in this test isn't quick enough to boot up. Now we wait for the server to boot up. Signed-off-by: Benjamin Wohlwend <beni@elastic.co>
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Jul 16, 2018
see elastic#259 for context Signed-off-by: Benjamin Wohlwend <beni@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_urllib3 is quite flaky on appveyor. The assumption is that due to
the slow executor machine, the http server used in this test isn't
quick enough to boot up. Now we wait for the server to boot up.