httpx: fix httpcore instrumentation handling of default port#2669
Merged
Conversation
🤖 GitHub commentsJust comment with:
|
xrmx
force-pushed
the
fix-issue-2667
branch
2 times, most recently
from
b2420c6 to
a759069
Compare
Fix both sync and async instrumentation handling of the default port. If the port is set by the client it would be None so we should treat it as the default one. The async instrumentation also contained a typo when building the url. This has gone unnoticed since the tests using httpx will create DroppedSpans for httpcore spans.
trentm
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Fix both sync and async instrumentation handling of the default port. If the port is set by the client it would be None so we should treat it as the default one.
The async instrumentation also contained a typo when building the url.
This has gone unnoticed since the tests using httpx will create DroppedSpans for httpcore spans.
Related issues
Closes #2667