Skip to content

[Docs] Add frame context to tuning.asciidoc #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2018
Merged

[Docs] Add frame context to tuning.asciidoc #311

merged 1 commit into from
Nov 6, 2018

Conversation

@bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Oct 30, 2018 •
edited
Loading

@bmorelli25 bmorelli25 self-assigned this Oct 30, 2018
@bmorelli25 bmorelli25 requested a review from beniwohli October 30, 2018 18:27
beniwohli
beniwohli reviewed Nov 6, 2018
View reviewed changes
Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmorelli25 awesome stuff, sorry that it took so long for me to get around to have a look!

I wonder if it would make sense to mention that the default settings for frame context capturing are already quite conservative, as we don't capture any for spans, only for errors. OTOH, we'd have to remember to update both places if we ever change the defaults...

@bmorelli25
Copy link
Member Author

bmorelli25 commented Nov 6, 2018

I left that information out because the other settings on that page don't mention defaults, they only link to them - so I was trying to maintain that structure.

@beniwohli
Copy link
Contributor

beniwohli commented Nov 6, 2018

@bmorelli25 makes sense! Feel free to merge!

(btw, can you use Squash & Merge? no biggie, just prefer not to have merge commits in master)

The two failing test runs are unrelated. Working on fixing that situation, but that shouldn't hold this up.

@bmorelli25 bmorelli25 merged commit a3f9ae9 into elastic:master Nov 6, 2018
@bmorelli25 bmorelli25 deleted the 218-frame-context-settings branch November 6, 2018 15:27
beniwohli pushed a commit that referenced this pull request Nov 7, 2018
@bmorelli25 @beniwohli
docs: add frame context to tuning (#311)
5d61408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@beniwohli beniwohli beniwohli left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bmorelli25 bmorelli25

Labels

docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add frame context line settings paragraph to Tuning & Overhead doc

2 participants

@bmorelli25 @beniwohli