Skip to content

ci(jenkins): delegate docker setup to the preCommit step #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 14, 2019
Merged

ci(jenkins): delegate docker setup to the preCommit step #557

merged 5 commits into from
Aug 14, 2019

Conversation

@v1v
Copy link
Member

@v1v v1v commented Aug 13, 2019 •
edited
Loading

Highlights

  • preCommit step provides support to the dockerImage requirement.

Reasons

  • Docker login is not required for this particular sanity checks.
  • Docker login does not work within the context of the docker.image.

@v1v v1v self-assigned this Aug 13, 2019
@v1v v1v changed the title ci(jenkins): docker login is not required within the docker.image closure ci(jenkins): delegate docker setup to the preCommit step Aug 13, 2019
@v1v v1v requested a review from mdelapenya August 13, 2019 10:27
@v1v v1v requested a review from beniwohli August 13, 2019 11:26
@v1v v1v merged commit b4fc446 into elastic:master Aug 14, 2019
@v1v v1v deleted the feature/skipDockerLogin branch August 14, 2019 07:44
@v1v v1v mentioned this pull request Aug 14, 2019
Merged
v1v added a commit that referenced this pull request Aug 14, 2019
@v1v
Revert "ci(jenkins): delegate docker setup to the preCommit step (#557)"
b468a38 
This reverts commit b4fc446.
@v1v v1v mentioned this pull request Aug 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beniwohli beniwohli Awaiting requested review from beniwohli

1 more reviewer

@mdelapenya mdelapenya mdelapenya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@v1v v1v

Labels

automation ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@v1v @mdelapenya