Skip to content

ci(jenkins): the environment GIT_BASE_COMMIT is not accessible #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 23, 2019
Merged

ci(jenkins): the environment GIT_BASE_COMMIT is not accessible #569

merged 4 commits into from
Aug 23, 2019

Conversation

@v1v
Copy link
Member

@v1v v1v commented Aug 23, 2019 •
edited
Loading

Highlights

  • ci(jenkins): avoid using the any agent to skip running in the master-worker #568 caused a regression as the env variable is defined at the worker level.
  • @Field helps to create global variables, therefore gitCommit is the new variable which does substitute the environment variable.
  • Avoid using a worker for running the tests, and reuse the top-level one
  • GIT_SHA rather than GIT_BASE_COMMIT as the last one is caused when doing a merge within a PR.

v1v added 2 commits August 23, 2019 08:33
@v1v
ci(jenkins): this is required as the environment GIT_BASE_COMMIT is d…
e70c18c 
…efined in the agent within the Initializing stage
@v1v
Revert "ci(jenkins): this is required as the environment GIT_BASE_COM…
02416ac 
…MIT is defined in the agent within the Initializing stage"

This reverts commit e70c18c.
@v1v v1v self-assigned this Aug 23, 2019
@v1v
ci(jenkins): this is required as the environment GIT_BASE_COMMIT is d…
295d79f 
…efined in the agent within the Initializing stage
@v1v v1v force-pushed the fix/missingparam branch from b4ac287 to 295d79f Compare August 23, 2019 08:10
@v1v v1v requested a review from mdelapenya August 23, 2019 11:05
@v1v v1v merged commit 2562886 into elastic:master Aug 23, 2019
@v1v v1v deleted the fix/missingparam branch August 23, 2019 11:29
@mdelapenya mdelapenya mentioned this pull request Aug 26, 2019
Merged
v1v added a commit to v1v/apm-agent-python that referenced this pull request Aug 27, 2019
@v1v
Revert "ci(jenkins): the environment GIT_BASE_COMMIT is not accessible (
8de90b7 
elastic#569)"

This reverts commit 2562886.
@v1v v1v mentioned this pull request Aug 27, 2019
Merged
v1v added a commit that referenced this pull request Aug 27, 2019
@v1v
ci(jenkins): revert none agent (#572)
9e50016 
* Revert "ci(jenkins): the environment GIT_BASE_COMMIT is not accessible (#569)"
This reverts commit 2562886.
* Revert "ci(jenkins): avoid using the any agent to skip running in the master-worker (#568)"
This reverts commit f99a65b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mdelapenya mdelapenya mdelapenya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@v1v v1v

Labels

automation bug ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@v1v @mdelapenya