Skip to content

Conversation

@basepi
Copy link
Contributor

@basepi basepi commented Sep 3, 2019

  • Need to use gtar on macOS to get --wildcard support for make json schema
  • Add psutil to requirement-base.txt for test_send_remote_failover_sync_non_transport_exception_error
    • Turns I just needed to fix the test properly, by disabling metrics_sets for that test.
  • Update .gitignore with a couple of testing artifacts
  • Fix a documentation bug around syntax for tests/scripts/docker/run_tests.sh
  • Add a note about apm-integration-testing

@basepi basepi requested a review from beniwohli September 3, 2019 18:12
Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

Use gtar instead of tar
Had a unit test failure without it installed:

test_send_remote_failover_sync_non_transport_exception_error
test_send_remote_failover_sync_non_transport_exception_error isn't
concerned with metrics, so just disable the metrics sets.
@basepi basepi merged commit bb34b27 into elastic:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants