Skip to content

Conversation

@beniwohli
Copy link
Contributor

@beniwohli beniwohli commented Sep 25, 2019

we can't upgrade to 5.0 due to its lack of support for Python 2

Main driver behind this update was the introduction of --ignore-glob that allows us to define a file name prefix py3_ which can then be excluded in Python 2 tests, giving us the option to have tests with Python 3 syntax

we can't upgrade to 5.0 due to its lack of support for Python 2
@beniwohli beniwohli requested a review from basepi September 25, 2019 14:38
@beniwohli beniwohli self-assigned this Sep 25, 2019
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the only failure is the transient Windows one, so I say merge it so we can get #596 green!

@beniwohli beniwohli merged commit d0f2a39 into elastic:master Sep 25, 2019
@beniwohli beniwohli deleted the update-pytest branch September 25, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants