ci: grab Docker containers logs #719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuisathaverat
changed the title
kuisathaverat
changed the title
v1v
approved these changes
Feb 17, 2020
| secret: "${steps.env.CODECOV_SECRET}") | ||
| secret: "${steps.env.CODECOV_SECRET}" | ||
| ) | ||
| dir("${steps.env.BASE_DIR}/tests"){ |
Member
There was a problem hiding this comment.
could this section be moved earlier? Just in case the codecov step failed then this section won't be executed, what do you think?
beniwohli
pushed a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* feat: grab Docker containers logs * chore: cosmetic changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
It grabs the Docker containers logs before to destroy the containers.
Why is it important?
In order to diagnose some issues sometimes, we need the Docker container logs.
Related issues
related to #718