Skip to content

fix: define the mandatory POSTGRES_PASSWORD environment variable #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 17, 2020
Merged

fix: define the mandatory POSTGRES_PASSWORD environment variable #720

merged 5 commits into from
Feb 17, 2020

Conversation

@kuisathaverat
Copy link
Contributor

@kuisathaverat kuisathaverat commented Feb 17, 2020

What does this pull request do?

It adds POSTGRES_PASSWORD environment variable to the docker-compose and tests.

Why is it important?

The latest PostgresQL Docker image request to use a password for the superuser or trust on all connections.

Error: Database is uninitialized and superuser password is not specified.
       You must specify POSTGRES_PASSWORD for the superuser. Use
       "-e POSTGRES_PASSWORD=password" to set it in "docker run".

       You may also use POSTGRES_HOST_AUTH_METHOD=trust to allow all connections
       without a password. This is *not* recommended. See PostgreSQL
       documentation about "trust":
       https://www.postgresql.org/docs/current/auth-trust.html

Related issues

closes #718

@kuisathaverat kuisathaverat requested review from a team, basepi and beniwohli February 17, 2020 11:28
beniwohli
beniwohli approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Guess it worked locally for me because docker-compose didn't pull the new image but used a cached one instead.

@kuisathaverat kuisathaverat merged commit 60402da into elastic:master Feb 17, 2020
@kuisathaverat kuisathaverat deleted the POSTGRES_PASSWORD branch February 17, 2020 13:39
beniwohli pushed a commit to beniwohli/apm-agent-python that referenced this pull request Sep 14, 2021
@kuisathaverat @beniwohli
fix: define the mandatory POSTGRES_PASSWORD environment variable (ela…
bc2f7f1 
…stic#720)

* feat: grab Docker containers logs

* fix: define the mandatory POSTGRES_PASSWORD environment variable

* fix: add missing parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cachedout cachedout cachedout approved these changes

@v1v v1v v1v approved these changes

@basepi basepi Awaiting requested review from basepi

+2 more reviewers

@beniwohli beniwohli beniwohli approved these changes

@mdelapenya mdelapenya mdelapenya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

psycopg2 tests are failing in CI

5 participants

@kuisathaverat @beniwohli @cachedout @mdelapenya @v1v