Skip to content

Conversation

@v1v
Copy link
Member

@v1v v1v commented Feb 20, 2020

What does this pull request do?

Install python with the version that's the same that the given VERSION or the closest one. Therefore the VERSION format could be:

  • fully
  • major
  • major.minor
  • semver...

Why is it important?

It will help to install python3 in windows just given the major.minor version rather than the major.minor.patch version

Related issues

Caused by #726

Tests

$Env:VERSION = "3.8"
.\install-python.ps1

image

@v1v v1v self-assigned this Feb 20, 2020
@v1v v1v added the automation label Feb 20, 2020
@v1v v1v requested a review from a team February 20, 2020 09:17
@v1v v1v marked this pull request as ready for review February 20, 2020 09:20
Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@v1v
Copy link
Member Author

v1v commented Feb 21, 2020

Most likely we will provide a new step in our shared library to help with the CI pipeline and keep those implementation details in one place.
I'll merge this PR for the time being, then @ElWPenn could potentially use this script in his ongoing PR.

@v1v v1v merged commit 9bf63bc into elastic:master Feb 21, 2020
@v1v v1v deleted the feature/install-python-version-windows branch February 21, 2020 08:09
beniwohli pushed a commit to beniwohli/apm-agent-python that referenced this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants