ci(jenkins): use CI Windows workers #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
force-pushed
the
feature/windows-builds-ci
branch
from
a0f3852 to
4c8af8a
Compare
Contributor
|
Is this a replacement for #726? I think for now, we can set |
Member
Author
|
@beniwohli , yes, I'm working on a separate PR for the same requirement. |
…nt installed configuration in the CI Windows worker
v1v
commented
Mar 9, 2020
| BENCHMARK_SECRET = 'secret/apm-team/ci/benchmark-cloud' | ||
| OPBEANS_REPO = 'opbeans-python' | ||
| HOME = "${env.WORKSPACE}" | ||
| PATH = "${env.WORKSPACE}/.local/bin:${env.WORKSPACE}/bin:${env.PATH}" |
Member
Author
There was a problem hiding this comment.
Otherwise, there will be a clash in the CI Windows workers
Jenkinsfile
Outdated
|
|
||
| // Let's now enable the windows stages | ||
| readYaml(file: '.ci/.jenkins_windows.yml')['windows'].each { v -> | ||
| def description = "${v.VERSION}-${v.DISTUTILS_USE_SDK.equals('1') ? 'use-sdk' : ''}-${v.WEBFRAMEWORK}" |
Member
Author
There was a problem hiding this comment.
This will help to run the same version with different parameters, for such the primary key is a combination of VERSION, DISTUTILS_USE_SDK and WEBFRAMEWORK.
Jenkinsfile
Outdated
| deleteDir() | ||
| unstash 'source' | ||
| dir("${BASE_DIR}"){ | ||
| installTools([ [tool: "python${majorVersion}", version: "${version}" ] ]) |
Member
Author
There was a problem hiding this comment.
This will help to install python2 and python3.
…refactored in the future
v1v
changed the title
beniwohli
approved these changes
Mar 10, 2020
Contributor
beniwohli
left a comment
beniwohli
left a comment
There was a problem hiding this comment.
Awesome stuff!
Could you try to also add Python 3.8?
cachedout
reviewed
Mar 10, 2020
cachedout
approved these changes
Mar 10, 2020
beniwohli
pushed a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Replace AppVeyor with CI Jenkins.
Configuration-driven, therefore if a new python version is required then it should be added to the file
.ci/.jenkins_windows.ymlPython versions that are supported so far:
3.53.63.73.8Why is it important?
No more dependencies with AppVeyor.
Related issues
closes #ISSUE
Actions
Follow-ups
2.7