Skip to content

Change cloud_provider default to True #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2020
Merged

Change cloud_provider default to True #875

merged 1 commit into from
Jun 30, 2020

Conversation

@basepi
Copy link
Contributor

@basepi basepi commented Jun 30, 2020

Ref #826

@basepi basepi requested a review from beniwohli June 30, 2020 14:57
beniwohli
beniwohli approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghost
Copy link

ghost commented Jun 30, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #875 opened]

  • Start Time: 2020-06-30T14:57:16.039+0000

  • Duration: 28 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 10672
Skipped 7953
Total 18625

Steps errors

Expand to view the steps failures

  • Name: Shell Script

    • Description: ./tests/scripts/docker/run_tests.sh pypy-3 none

    • Duration: 3 min 17 sec

    • Start Time: 2020-06-30T15:04:28.432+0000

    • log

@basepi basepi merged commit 0ed8984 into elastic:master Jun 30, 2020
romulorosa pushed a commit to romulorosa/apm-agent-python that referenced this pull request Oct 15, 2020
@basepi @romulorosa
Change cloud_provider default to True (elastic#875)
d13e83a
romulorosa pushed a commit to romulorosa/apm-agent-python that referenced this pull request Oct 15, 2020
@basepi @romulorosa
Change cloud_provider default to True (elastic#875)
7029b37
beniwohli pushed a commit to beniwohli/apm-agent-python that referenced this pull request Sep 14, 2021
@basepi @beniwohli
Change cloud_provider default to True (elastic#875)
46c20a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@beniwohli beniwohli beniwohli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@basepi @beniwohli