Open
Conversation
Update Go toolchain version across the project: - .go-version: 1.25.5 -> 1.26.1 - go.mod: 1.25.5 -> 1.26.1 - scripts/update_assets_md/go.mod: 1.24.0 -> 1.26.1 - docs/version.asciidoc: 1.25.4 -> 1.26.1 - Rename Hermit package bin/.go-1.25.5.pkg -> bin/.go-1.26.1.pkg
fa8f318 to
c7c1ece
Compare
golangci-lint 2.4.0 was built with Go 1.25 and refuses to lint Go 1.26.1 target code. Upgrade to 2.11.3 (built with Go 1.26.1) and address new lint findings: - Disable newly introduced revive rules that flag pre-existing code patterns (package-directory-mismatch, enforce-switch-style, use-waitgroup-go, use-slices-sort, identical-switch-branches, package-naming) - Fix 3 prealloc issues by preallocating slices with known capacity
|
This pull request does not have a backport label. Could you fix it @olegsu? 🙏
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Go version bump
.go-versiongo.modscripts/update_assets_md/go.moddocs/version.asciidocbin/.go-1.25.5.pkgbin/.go-1.26.1.pkgbin/go.go-1.25.5.pkg.go-1.26.1.pkgbin/gofmt.go-1.25.5.pkg.go-1.26.1.pkggolangci-lint upgrade
bin/.golangci-lint-2.4.0.pkgbin/.golangci-lint-2.11.3.pkgbin/golangci-lint.golangci-lint-2.4.0.pkg.golangci-lint-2.11.3.pkg.golangci.yamlPrealloc fixes
internal/resources/fetching/fetchers/azure/assets_enricher.gointernal/resources/providers/awslib/rds/provider.gointernal/resources/providers/gcplib/inventory/provider.goTest plan
golangci-lint runexits 0)