agent-docker-build: add -y to "microdnf update" command#3703
Merged
Conversation
currently it looks like: ``` ❯ make agent-docker-build ... => [ 2/11] RUN microdnf update && microdnf install -y vim wget git make python3.11 python3.11-pip && microdnf clean all 18.6s => => # Reinstalling: 0 packages => => # Upgrading: 37 packages => => # Obsoleting: 0 packages => => # Removing: 0 packages => => # Downgrading: 0 packages => => # Is this ok [y/N]: ``` and now it's waiting for user input, but console is redirected, so any keyboard input is ignored. So, looking that `install` command already has `-y`, I assumed that adding `-y` to `update` is also safe enough.
lorenabalan
approved these changes
Sep 18, 2025
Contributor
lorenabalan
left a comment
There was a problem hiding this comment.
LGTM - shall we add more backporting labels?
artem-shelkovnikov
approved these changes
Sep 18, 2025
💔 Failed to create backport PR(s)
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
Member
|
Yeah no point backporting to 8.x |
artem-shelkovnikov
pushed a commit
that referenced
this pull request
Sep 18, 2025
artem-shelkovnikov
pushed a commit
that referenced
this pull request
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently it looks like:
and now it's waiting for user input, but console is redirected, so any keyboard input is ignored.
So, looking that
installcommand already has-y, I assumed that adding-ytoupdateis also safe enough.Checklists
Pre-Review Checklist
config.yml.example)