Skip to content

agent-docker-build: add -y to "microdnf update" command#3703

Merged
zed-0xff merged 2 commits into
mainfrom
zed/microdnf-update-assumeyes
Sep 18, 2025
Merged

agent-docker-build: add -y to "microdnf update" command#3703
zed-0xff merged 2 commits into
mainfrom
zed/microdnf-update-assumeyes

Conversation

@zed-0xff
Copy link
Copy Markdown
Contributor

@zed-0xff zed-0xff commented Sep 18, 2025

currently it looks like:

❯ make agent-docker-build
...
 => [ 2/11] RUN microdnf update && microdnf install -y   vim   wget   git   make   python3.11   python3.11-pip   && microdnf clean all                                                          18.6s
 => => #  Reinstalling:      0 packages
 => => #  Upgrading:        37 packages
 => => #  Obsoleting:        0 packages
 => => #  Removing:          0 packages
 => => #  Downgrading:       0 packages
 => => # Is this ok [y/N]:

and now it's waiting for user input, but console is redirected, so any keyboard input is ignored.

So, looking that install command already has -y, I assumed that adding -y to update is also safe enough.

Checklists

Pre-Review Checklist

  • this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Tested the changes locally

currently it looks like:
```
❯ make agent-docker-build
...
 => [ 2/11] RUN microdnf update && microdnf install -y   vim   wget   git   make   python3.11   python3.11-pip   && microdnf clean all                                                          18.6s
 => => #  Reinstalling:      0 packages
 => => #  Upgrading:        37 packages
 => => #  Obsoleting:        0 packages
 => => #  Removing:          0 packages
 => => #  Downgrading:       0 packages
 => => # Is this ok [y/N]:
```
and now it's waiting for user input, but console is redirected, so any keyboard input is ignored.

So, looking that `install` command already has `-y`, I assumed that adding `-y` to `update` is also safe enough.
Copy link
Copy Markdown
Contributor

@lorenabalan lorenabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - shall we add more backporting labels?

@github-actions
Copy link
Copy Markdown

💔 Failed to create backport PR(s)

Status Branch Result
9.0 #3704
8.17 Commit could not be cherrypicked due to conflicts
8.18 Commit could not be cherrypicked due to conflicts
9.1 #3705
8.19 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 3703 --autoMerge --autoMergeMethod squash

@artem-shelkovnikov
Copy link
Copy Markdown
Member

Yeah no point backporting to 8.x

artem-shelkovnikov pushed a commit that referenced this pull request Sep 18, 2025
artem-shelkovnikov pushed a commit that referenced this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants