Skip to content

Conversation

@mattnowzari
Copy link
Contributor

@mattnowzari mattnowzari commented Apr 29, 2025

Closes #283

This PR aims to update our release-pipeline.yml file to allow building Docker images off of main branch. This is useful for generating SNAPSHOT images.

Checklists

Pre-Review Checklist

  • This PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check crawler.yml.example and elasticsearch.yml.example)
  • This PR has a meaningful title
  • This PR links to all relevant GitHub issues that it fixes or partially addresses
    • If there is no GitHub issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Added a label for each target release version (example: v0.1.0)

@mattnowzari mattnowzari marked this pull request as ready for review April 29, 2025 17:50
@mattnowzari mattnowzari requested a review from a team as a code owner April 29, 2025 17:50
@mattnowzari mattnowzari changed the title Updating pipeline.yml to support building Docker images from main branch Updating release-pipeline.yml to support building Docker images from main branch Apr 29, 2025
@mattnowzari mattnowzari marked this pull request as draft April 29, 2025 21:15
Copy link
Contributor

@jedrazb jedrazb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the main branch left out intentionally? If we build from main will it be clear in the docker img that this is a snapshot build not an official release?

@mattnowzari
Copy link
Contributor Author

Currently Crawler's pipelines have a UI element that allow us to specify specific builds as snapshots - I've moved this PR back to draft so I can experiment with automatically having builds from main be snapshot builds without specifying with a UI prompt - hopefully it is possible! 😄

IS_SNAPSHOT=$(buildkite-agent meta-data get is_snapshot)

- input: "Build information"
fields:
- select: "Build as a SNAPSHOT?"
key: "is_snapshot"
options:
- label: "Yes"
value: "true"
- label: "No"
value: "false"

@mattnowzari mattnowzari marked this pull request as ready for review April 30, 2025 20:06
expectedOutput: ["jruby\\s9\\.4\\.*"]
- name: "Crawler installation"
command: "/app/bin/crawler"
command: "/home/app/bin/crawler"
Copy link
Contributor Author

@mattnowzari mattnowzari Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI for reviewer - this changed bc of work done here --> #248

Our builds just haven't failed bc we haven't actually made any builds since that PR 🤣

Copy link
Member

@seanstory seanstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. It removes our ability to do on-demand SNAPSHOT builds, but I think that's probably ok, especially since you're planning to come back later and add nightlies. Nice work.

@mattnowzari mattnowzari merged commit 11ccd9b into main Apr 30, 2025
2 checks passed
@mattnowzari mattnowzari deleted the release_from_main branch April 30, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve release pipeline to allow builds off of main branch

4 participants