-
Notifications
You must be signed in to change notification settings - Fork 41
Updating release-pipeline.yml to support building Docker images from main branch #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jedrazb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the main branch left out intentionally? If we build from main will it be clear in the docker img that this is a snapshot build not an official release?
|
Currently Crawler's pipelines have a UI element that allow us to specify specific builds as snapshots - I've moved this PR back to draft so I can experiment with automatically having builds from
crawler/.buildkite/release-pipeline.yml Lines 5 to 13 in 712026c
|
| expectedOutput: ["jruby\\s9\\.4\\.*"] | ||
| - name: "Crawler installation" | ||
| command: "/app/bin/crawler" | ||
| command: "/home/app/bin/crawler" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI for reviewer - this changed bc of work done here --> #248
Our builds just haven't failed bc we haven't actually made any builds since that PR 🤣
seanstory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. It removes our ability to do on-demand SNAPSHOT builds, but I think that's probably ok, especially since you're planning to come back later and add nightlies. Nice work.
Closes #283
This PR aims to update our
release-pipeline.ymlfile to allow building Docker images off ofmainbranch. This is useful for generating SNAPSHOT images.Checklists
Pre-Review Checklist
crawler.yml.exampleandelasticsearch.yml.example)v0.1.0)