Address missing months time unit
#120
Conversation
There was a problem hiding this comment.
Cant this be init'd to
target_date = utc_now
It is all relative to now right?
There was a problem hiding this comment.
No, because date objects and datetime objects are different. I have to reference year and month separately here, and I also want each month to be calculated based on the 1st.
There was a problem hiding this comment.
I had that idea too, though. I tried it that way first, and it didn't work. I learned I had to convert 😄
|
LGTM, minor comments |
test_curator/integration/__init__.py
Outdated
There was a problem hiding this comment.
His pythonness, Honza, himself put that there. I thought it was odd, but a really cool shortcut now that I know it can be done.
There was a problem hiding this comment.
Ah, I see. It's because timedelta uses kwargs. This converts it into the format desired.
Expanded out, it actually would say something like:
step = timedelta(days=1)
So, **{unit: 1} becomes days=1
There was a problem hiding this comment.
yep I saw that a soon as I tried writing timedelta(unit=1) in python and it was like NO. ;P
Thanks much for clarifying.
|
+1 on idea, <3 for tests. Any inline comments I made are minor questions. |
Add tests for monthly data Updated CHANGELOG Removed unnecessary client var from calls to Fixed missing newline Added time_unit arguments Filter out '.marvel-kibana' index so it does not appear in logs Update README.md to show as viable option Added datemap with default datestrings. Switched while loop to be range() Changed while loop to range(). Using default datemap from curator.py Updated CHANGELOG
3 participants
The new
--timestringoption allows for monthly index patterns, e.g.logstash-2014.07, but because python'stimedeltafunction does not recognize months as a time unit, this functionality was omitted from the 1.2.0 release.This PR addresses this completely, with tests. It also patches a few other nits.