Skip to content

[Bug] Base requirements not sufficient to run detection_rules module #4724

@willbrownecs

Description

@willbrownecs

Describe the Bug

Installing the base dependencies (not the optional dev/hunting dependencies) is no longer sufficient to run the detection_rules module.

Installing the dev dependencies resolves the issue. uv sync --extra dev

To Reproduce

  1. uv sync
  2. uv run -m detection_rules
  3. observe the missing github module:
Traceback (most recent call last):
  File "<frozen runpy>", line 189, in _run_module_as_main
  File "<frozen runpy>", line 148, in _get_module_details
  File "<frozen runpy>", line 112, in _get_module_details
  File "/home/will/repos/adversary_pursuit-detection_rules/detection_rules/__init__.py", line 13, in <module>
    from . import (  # noqa: E402
  File "/home/will/repos/adversary_pursuit-detection_rules/detection_rules/custom_schemas.py", line 14, in <module>
    from .config import parse_rules_config
  File "/home/will/repos/adversary_pursuit-detection_rules/detection_rules/config.py", line 17, in <module>
    from .misc import discover_tests
  File "/home/will/repos/adversary_pursuit-detection_rules/detection_rules/misc.py", line 21, in <module>
    from .utils import add_params, cached, get_path, load_etc_dump
  File "/home/will/repos/adversary_pursuit-detection_rules/detection_rules/utils.py", line 30, in <module>
    from github.Repository import Repository
ModuleNotFoundError: No module named 'github'

Expected Behavior

Expect the detection_rules CLI to run without the dev dependencies

Screenshots

No response

Desktop - OS

Linux

Desktop - Version

WSL - Ubuntu 24.04.2 LTS (Noble Numbat)"

Additional Context

I acknowledge that I am using uv instead of the recommended pip installation method, but this method worked prior to an update which added the usage of the github module

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions