-
Notifications
You must be signed in to change notification settings - Fork 609
[FR] Support forked rules with 100 version buffer space #1946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
168d2f6
add an array to the metadata section within the rules to bring awaren…
Mikaayenson cc8ee77
add buffer space
Mikaayenson 6ef8307
support locking old stack version if we have buffer space
Mikaayenson dee9db9
Merge branch 'main' into 1935-fr-support-forked-rules
Mikaayenson 6c3e4ab
set buffer_int to 99 since we start version at 1
Mikaayenson c31a2de
cleanup todo
Mikaayenson 8e9e0ff
update message with recommendation to deprecate
Mikaayenson 87fa929
ensure version lock is bumped 100 buffer spaces
Mikaayenson 7605308
Merge branch 'main' into 1935-fr-support-forked-rules
Mikaayenson 2c62229
add forked rules to the latest rule version methods
Mikaayenson 8bfb3d7
update rule version
Mikaayenson fe5bb20
only bump the version and try to add a buffer if we have the space
Mikaayenson 5e41be1
Merge branch 'main' into 1935-fr-support-forked-rules
Mikaayenson 2c2fa92
Merge branch 'main' into 1935-fr-support-forked-rules
Mikaayenson 38478c6
Merge branch 'main' into 1935-fr-support-forked-rules
Mikaayenson 2e94a7b
update to latest version_lock and rule edits
Mikaayenson 40eecaa
reset version_lock and rule files
Mikaayenson f9850ea
Merge branch 'main' into 1935-fr-support-forked-rules
Mikaayenson 1f0d9a1
readd changes
Mikaayenson f832f17
bump buffer space 100
Mikaayenson a900229
WIP: hold before adding func for rare edge case
Mikaayenson 062b61b
Merge branch 'main' into 1935-fr-support-forked-rules
Mikaayenson 4767d75
Update detection_rules/rule.py
Mikaayenson 2334d16
Merge branch 'main' into 1935-fr-support-forked-rules
Mikaayenson dfb2c13
Merge branch 'main' into 1935-fr-support-forked-rules
Mikaayenson 764dafa
Merge branch 'main' into 1935-fr-support-forked-rules
Mikaayenson f39f675
Merge branch 'main' into 1935-fr-support-forked-rules
Mikaayenson 8390e75
Merge branch 'main' into 1935-fr-support-forked-rules
Mikaayenson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to make sure we dont also include the rule version autobump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if excluding version update, shouldn't the buffer be skipped too?