Add test that newly introduced build-time fields for a min_stack for … #2262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…applicable rules.
brokensound77
requested review from
Mikaayenson and
terrancedejesus
as code owners
5 tasks
Mikaayenson
approved these changes
Aug 24, 2022
terrancedejesus
approved these changes
Aug 24, 2022
| invalids = [] | ||
|
|
||
| for rule in self.production_rules: | ||
| min_stack = rule.contents.metadata.min_stack_version |
Contributor
There was a problem hiding this comment.
Will we never use soft-forking then, only hard-forking from the metadata field??
Contributor
Author
There was a problem hiding this comment.
based on our last discussions, I don't think it is supportable (or advisable)
5 tasks
Contributor
Author
|
I realized this would fail when backported to <8.3 branches and in general for branches <= build enforcement, so I added a constraint to check the current version for each build field in b2bec63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
related to #2251
Summary
Build-time fields create changes to rule hashes without being accounted for explicitly within the version lock (essentially creating a "soft" lock). This is problematic because it creates a buggy situation where non-latest rules version bump every time due to the delta hash resulting from the differences from the build time fields. To address this, build time field introduction requires that all fields.
This adds a test to enforce that on any defined build time rule