-
Notifications
You must be signed in to change notification settings - Fork 609
Add test command to verify version collisions do not occur #2272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brokensound77
merged 13 commits into
elastic:main
from
brokensound77:version-collision-test
Sep 19, 2022
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
95d17ff
Add test command to verify version collisions do not occur
brokensound77 4ec089b
Merge branch 'main' into version-collision-test
brokensound77 e4fd24c
Merge branch 'main' into version-collision-test
brokensound77 ddd4614
add max_allowable_version to schema and lock flow
brokensound77 465181d
add max_allowable_version to all entries in version.lock
brokensound77 1ab35b4
add test-version-lock command
brokensound77 4b56f20
use min supported stack if > locked min stack
brokensound77 5ffdc55
Merge branch 'main' into version-collision-test
brokensound77 501568a
share lock conversion code with rule and lock to fix M.m bug
brokensound77 06a4018
Merge branch 'main' into version-collision-test
brokensound77 f6fe9bb
share lock conversion code with rule and lock to fix M.m bug
brokensound77 11a3f27
Merge branch 'version-collision-test' of github.com:brokensound77/det…
brokensound77 ecbb8a5
Merge branch 'main' into version-collision-test
brokensound77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We potentially could run this in all unit tests where a rule file is changed to be really thorough, but I think for now we should leave it as a manual command