[Bug] Adding Adjustment to Route C of manage_versions.py #2307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrancedejesus
added
bug
terrancedejesus
requested review from
Mikaayenson and
brokensound77
as code owners
brokensound77
approved these changes
Sep 19, 2022
Contributor
brokensound77
left a comment
brokensound77
left a comment
There was a problem hiding this comment.
LGTM - after merging can you run a test lock
protectionsmachine
pushed a commit
that referenced
this pull request
Sep 19, 2022
(cherry picked from commit 3c97d34)
protectionsmachine
pushed a commit
that referenced
this pull request
Sep 19, 2022
(cherry picked from commit 3c97d34)
protectionsmachine
pushed a commit
that referenced
this pull request
Sep 19, 2022
(cherry picked from commit 3c97d34)
protectionsmachine
pushed a commit
that referenced
this pull request
Sep 19, 2022
(cherry picked from commit 3c97d34)
protectionsmachine
pushed a commit
that referenced
this pull request
Sep 19, 2022
(cherry picked from commit 3c97d34)
protectionsmachine
pushed a commit
that referenced
this pull request
Sep 19, 2022
(cherry picked from commit 3c97d34)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Summary
Adjusted route C to update the dictionary for the
lock_from_filevariable asmax_allowable_versionwas overwritten and therefore did not exist in the output.Testing:
command_and_control_telnet_port_activity.tomlin rule contentspython -m detection_rules dev build-release --update-version-lockversion.lock.jsonfile and noticemax_allowable_versionis missingBug Screenshot:
Solution Screenshot:
