-
Notifications
You must be signed in to change notification settings - Fork 609
[New Rule] GitHub Owner Role Granted to User #3087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
imays11
merged 8 commits into
main
from
3084-new-rule-organization-owner-role-granted-to-user
Oct 6, 2023
Merged
[New Rule] GitHub Owner Role Granted to User #3087
imays11
merged 8 commits into
main
from
3084-new-rule-organization-owner-role-granted-to-user
Oct 6, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/elastic/detection-rules into 3084-new-rule-organization-owner-role-granted-to-user
Aegrah
approved these changes
Sep 13, 2023
Contributor
Aegrah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after above nits.
rules/integrations/github/persistence_organization_owner_role_granted.toml
Outdated
Show resolved
Hide resolved
rules/integrations/github/persistence_organization_owner_role_granted.toml
Outdated
Show resolved
Hide resolved
brokensound77
approved these changes
Sep 13, 2023
Contributor
brokensound77
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with @Aegrah suggestions
terrancedejesus
approved these changes
Sep 14, 2023
Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com>
protectionsmachine
pushed a commit
that referenced
this pull request
Oct 6, 2023
* [New Rule] GitHub Owner Role Granted to User new rule * Update persistence_organization_owner_role_granted.toml * updated integration schema * changed timestamp_override * Apply suggestions from code review Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> --------- Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> (cherry picked from commit 9593412)
protectionsmachine
pushed a commit
that referenced
this pull request
Oct 6, 2023
* [New Rule] GitHub Owner Role Granted to User new rule * Update persistence_organization_owner_role_granted.toml * updated integration schema * changed timestamp_override * Apply suggestions from code review Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> --------- Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> (cherry picked from commit 9593412)
protectionsmachine
pushed a commit
that referenced
this pull request
Oct 6, 2023
* [New Rule] GitHub Owner Role Granted to User new rule * Update persistence_organization_owner_role_granted.toml * updated integration schema * changed timestamp_override * Apply suggestions from code review Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> --------- Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> (cherry picked from commit 9593412)
protectionsmachine
pushed a commit
that referenced
this pull request
Oct 6, 2023
* [New Rule] GitHub Owner Role Granted to User new rule * Update persistence_organization_owner_role_granted.toml * updated integration schema * changed timestamp_override * Apply suggestions from code review Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> --------- Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> (cherry picked from commit 9593412)
protectionsmachine
pushed a commit
that referenced
this pull request
Oct 6, 2023
* [New Rule] GitHub Owner Role Granted to User new rule * Update persistence_organization_owner_role_granted.toml * updated integration schema * changed timestamp_override * Apply suggestions from code review Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> --------- Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> (cherry picked from commit 9593412)
protectionsmachine
pushed a commit
that referenced
this pull request
Oct 6, 2023
* [New Rule] GitHub Owner Role Granted to User new rule * Update persistence_organization_owner_role_granted.toml * updated integration schema * changed timestamp_override * Apply suggestions from code review Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> --------- Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> (cherry picked from commit 9593412)
protectionsmachine
pushed a commit
that referenced
this pull request
Oct 6, 2023
* [New Rule] GitHub Owner Role Granted to User new rule * Update persistence_organization_owner_role_granted.toml * updated integration schema * changed timestamp_override * Apply suggestions from code review Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> --------- Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> (cherry picked from commit 9593412)
protectionsmachine
pushed a commit
that referenced
this pull request
Oct 6, 2023
* [New Rule] GitHub Owner Role Granted to User new rule * Update persistence_organization_owner_role_granted.toml * updated integration schema * changed timestamp_override * Apply suggestions from code review Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> --------- Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> (cherry picked from commit 9593412)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport: auto
Domain: Cloud Workloads
Integration: GitHub
GitHub integration
Rule: New
Proposal for new rule
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#3084
Summary
This rule detects when a member is granted the organization owner role of a GitHub organization.
This role provides admin level privileges. Any new owner roles should be investigated to determine it's validity.
Unauthorized owner roles could indicate compromise within your organization and provide unlimited access to data and settings.