[Python] Ignore Hunting Doc Changes for Version Code Checks#4331
Conversation
Enhancement - GuidelinesThese guidelines serve as a reminder set of considerations when addressing adding a feature to the code. Documentation and Context
Code Standards and Practices
Testing
Additional Checks
|
|
Originally was it intended to capture only code changes for hunting as a "version upgrade". Asking thins because hunting queries are not version controlled via normal release process, so just want to be sure before we exclude. |
* Ignore hunting docs for version code checks * added index.md to be ignored --------- Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> (cherry picked from commit 1a189a5)
* Ignore hunting docs for version code checks * added index.md to be ignored --------- Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> (cherry picked from commit 1a189a5)
* Ignore hunting docs for version code checks * added index.md to be ignored --------- Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> (cherry picked from commit 1a189a5)
* Ignore hunting docs for version code checks * added index.md to be ignored --------- Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> (cherry picked from commit 1a189a5)
* Ignore hunting docs for version code checks * added index.md to be ignored --------- Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> (cherry picked from commit 1a189a5)
* Ignore hunting docs for version code checks * added index.md to be ignored --------- Co-authored-by: Ruben Groenewoud <78494512+Aegrah@users.noreply.github.com> (cherry picked from commit 1a189a5)
@shashank-elastic - apologies for your answer going unanswered. The hunting queries, at this time, are not product-driven and thus we did not add versioning to them intentionally as they are meant to serve the community. The TOML files are a foundational development step taken that may be important to future improvements or making these product-driven as originally we planned to just release MD docs. |
Pull Request
Issue link(s): N/A
Summary - What I changed
Added an file path exclusion to the pull request triggers for workflow
Version Code Check and Draft Release. This change will allow hunting pull requests to not require a patch version bump per new hunt added. As a reminder, hunting queries are developed and then the hunting CLI is used to convert the TOML to MD files. As such,**/*.mdis matching for these changes and thus requiring versions to be bumped in the repo. It also matches onindex.mdwhich is updated every hunting PR to catalogue the new hunts.How To Test
This has not been tested as it is a minor change, however, GitHub docs have been consulted to ensure formatting and sequential accuracy.
Checklist
bug,enhancement,schema,maintenance,Rule: New,Rule: Deprecation,Rule: Tuning,Hunt: New, orHunt: Tuningso guidelines can be generatedmeta:rapid-mergelabel if planning to merge within 24 hoursContributor checklist