Skip to content

Conversation

@imays11
Copy link
Contributor

@imays11 imays11 commented Oct 13, 2025

Pull Request

Issue link(s):

Summary - What I changed

All 3 rules triggering as expected, low telemetry volume. However, the same rule logic can be applied via EQL so I've changed the rule types for all 3 from ESQL to EQL. To provide better telemetry and alert context for users.

  • changed rule type to EQL and added iam as event.category
    • note: removed filebeat compatibility for the UpdateRolePolicy rule since event.category isn't mapped for this event in filebeat
  • updated all IGs
  • added highlighted fields
  • added index

How To Test

You can use this script to trigger each of the rules, change the MODE variable to group role or user depending on which rule you are trying to trigger. The script will create the resource and attach AdministratorAccess policy to it. You can do the same manually. There is test data in our shared stack to run query against.

Screenshot of each working EQL query

Screenshot 2025-10-13 at 1 03 24 PM Screenshot 2025-10-13 at 1 03 09 PM Screenshot 2025-10-13 at 1 02 48 PM

…Role/User

All 3 rules triggering as expected, low telemetry volume. However, the same rule logic can be applied via EQL so I've changed the rule types for all 3 from ESQL to EQL. To provide better telemetry and alert context for users.

- changed rule type to EQL
- updated all IGs
- added highlighted fields
- added index
@github-actions
Copy link
Contributor

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.

removed double note key
Copy link
Contributor

@shashank-elastic shashank-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking Linting in rules/integrations/aws/privilege_escalation_iam_administratoraccess_policy_attached_to_group.toml before merging

@imays11 imays11 merged commit 5f60e21 into main Oct 16, 2025
12 checks passed
@imays11 imays11 deleted the tune_aws_attach_administrator_access_policy branch October 16, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants