-
Notifications
You must be signed in to change notification settings - Fork 610
Skip unit test for protected prebuilt-rules on DAC env #5323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bug - GuidelinesThese guidelines serve as a reminder set of considerations when addressing a bug in the code. Documentation and Context
Code Standards and Practices
Testing
Additional Checks
|
Contributor
|
Independent testing 🟢 Details
detection-rules on issue-5283 is v1.5.13 via v3.12.12 (detection-rules-build) on eric.forte
❯ env | grep CUSTOM_RULES_DIR
detection-rules on issue-5283 is v1.5.13 via v3.12.12 (detection-rules-build) on eric.forte
❯ pytest tests/test_all_rules.py::TestIntegrationRules::test_preserve_upstream_protected_rule_id_name
===================================================================================================================== test session starts =====================================================================================================================
platform linux -- Python 3.12.12, pytest-9.0.1, pluggy-1.6.0
rootdir: /tmp/detection-rules
configfile: pyproject.toml
plugins: typeguard-4.4.4
collected 1 item
tests/test_all_rules.py . [100%]
================================================================================================================ 1 passed in 116.21s (0:01:56) ================================================================================================================
detection-rules on issue-5283 is v1.5.13 via v3.12.12 (detection-rules-build) on eric.forte took 2s
❯ export CUSTOM_RULES_DIR=/home/forteea1/Code/dac_demo/dac_clean/detection-rules/dac_test
detection-rules on issue-5283 is v1.5.13 via v3.12.12 (detection-rules-build) on eric.forte
❯ env | grep CUSTOM_RULES_DIR
CUSTOM_RULES_DIR=/home/forteea1/Code/dac_demo/dac_clean/detection-rules/dac_test
detection-rules on issue-5283 is v1.5.13 via v3.12.12 (detection-rules-build) on eric.forte
❯ pytest tests/test_all_rules.py::TestIntegrationRules::test_preserve_upstream_protected_rule_id_name
===================================================================================================================== test session starts =====================================================================================================================
platform linux -- Python 3.12.12, pytest-9.0.1, pluggy-1.6.0
rootdir: /tmp/detection-rules
configfile: pyproject.toml
plugins: typeguard-4.4.4
collected 1 item
tests/test_all_rules.py s [100%]
===================================================================================================================== 1 skipped in 1.08s ======================================================================================================================
|
eric-forte-elastic
approved these changes
Nov 17, 2025
Contributor
eric-forte-elastic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Peer review, looks good to me! 👍
Mikaayenson
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s): #5283
Summary - What I changed
How To Test
Unit Test on dev setup
Unit Test on DAC Setup
Checklist
bug,enhancement,schema,maintenance,Rule: New,Rule: Deprecation,Rule: Tuning,Hunt: New, orHunt: Tuningso guidelines can be generatedmeta:rapid-mergelabel if planning to merge within 24 hoursContributor checklist