Skip to content

Skip unit test for protected prebuilt-rules on DAC env #5323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2025
+2 βˆ’1
Merged

Skip unit test for protected prebuilt-rules on DAC env #5323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12e92c4
Skip unit test for protected prebuilt-rules on DAC env
shashank-elastic Nov 17, 2025
71ff794
Update Patch version
shashank-elastic Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "detection_rules"
version = "1.5.12"
version = "1.5.13"
description = "Detection Rules is the home for rules used by Elastic Security. This repository is used for the development, maintenance, testing, validation, and release of rules for Elastic Security’s Detection Engine."
readme = "README.md"
requires-python = ">=3.12"
Expand Down
1 change: 1 addition & 0 deletions tests/test_all_rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,6 +1112,7 @@ def test_ml_integration_jobs_exist(self):
f"The following ({len(failures)}) rules are missing a valid `machine_learning_job_id`:\n{err_msg}"
)

@unittest.skipIf(os.environ.get("CUSTOM_RULES_DIR"), "Skipping test for custom rules.")
def test_preserve_upstream_protected_rule_id_name(self):
"""
Ensure upstream referenced rule IDs and rule names remain unchanged
Expand Down
Loading