Skip to content

Conversation

@imays11
Copy link
Contributor

@imays11 imays11 commented Nov 21, 2025

Pull Request

Issue link(s):

Summary - What I changed

Completing Deprecation Process for this rule. It has now been included in our ruleset with Deprecated - prefix for 2 release cycles and should now be moved to our _deprecated folder.

Completing Deprecation Process for this rule. It has now been included in our ruleset with `Deprecated -` prefix for 2 release cycles and should now be moved to our `_deprecated` folder.
@github-actions
Copy link
Contributor

Rule: Deprecation - Guidelines

These guidelines serve as a reminder set of considerations when recommending the deprecation of a rule.

Documentation and Context

  • Description of the reason for deprecation.
  • Include any context or historical data supporting the deprecation decision.

Rule Metadata Checks

  • deprecated = true added to the rule metadata.
  • updated_date should be the date of the PR.

Testing and Validation

  • A prior rule tuning occurred for the rule where Deprecated - is prepended to the rule name, and the rule has already been released.
  • Rule has be moved to the _deprecated directory.
  • Double check gaps potentially or inadvertently introduced.
  • Provide evidence that the rule is no longer needed or has been replaced (e.g., alternative rules, updated detection methods).

@imays11 imays11 merged commit 497642d into main Nov 24, 2025
16 of 17 checks passed
@imays11 imays11 deleted the deprecate_aws_root_login_without_MFA branch November 24, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants