Skip to content

[Maintenance] Update .gitignore for AI Artifacts (Skills, MCP, etc.)#5833

Merged
terrancedejesus merged 2 commits intomainfrom
ignore-ai-artifacts
Mar 13, 2026
Merged

[Maintenance] Update .gitignore for AI Artifacts (Skills, MCP, etc.)#5833
terrancedejesus merged 2 commits intomainfrom
ignore-ai-artifacts

Conversation

@terrancedejesus
Copy link
Contributor

Pull Request

Issue link(s):
No issue link.

Summary - What I changed

Updates Git Ignore.

Claude Code — /.claude/, CLAUDE.md
Cursor — .cursorrules, .cursorignore, .cursor/
Aider — .aider*
GitHub Copilot — .github/copilot-instructions.md
Windsurf — .windsurfrules
Cline — .cline/, .clinerules

How To Test

Checklist

  • Added a label for the type of pr: bug, enhancement, schema, maintenance, Rule: New, Rule: Deprecation, Rule: Tuning, Hunt: New, or Hunt: Tuning so guidelines can be generated
  • Added the meta:rapid-merge label if planning to merge within 24 hours
  • Secret and sensitive material has been managed correctly
  • Automated testing was updated or added to match the most common scenarios
  • Documentation and comments were added for features that require explanation

Contributor checklist

@terrancedejesus terrancedejesus self-assigned this Mar 13, 2026
@terrancedejesus terrancedejesus added python Internal python for the repository maintenance Internal changes patch labels Mar 13, 2026
@terrancedejesus terrancedejesus marked this pull request as ready for review March 13, 2026 15:39
@github-actions
Copy link
Contributor

Enhancement - Guidelines

These guidelines serve as a reminder set of considerations when addressing adding a new schema feature to the code.

Documentation and Context

  • Describe the feature enhancement in detail (alternative solutions, description of the solution, etc.) if not already documented in an issue.
  • Include additional context or screenshots.
  • Ensure the enhancement includes necessary updates to the documentation and versioning.

Code Standards and Practices

  • Code follows established design patterns within the repo and avoids duplication.
  • Ensure that the code is modular and reusable where applicable.

Testing

  • New unit tests have been added to cover the enhancement.
  • Existing unit tests have been updated to reflect the changes.
  • Provide evidence of testing and validating the enhancement (e.g., test logs, screenshots).
  • Validate that any rules affected by the enhancement are correctly updated.
  • Ensure that performance is not negatively impacted by the changes.
  • Verify that any release artifacts are properly generated and tested.
  • Conducted system testing, including fleet, import, and create APIs (e.g., run make test-cli, make test-remote-cli, make test-hunting-cli)

Additional Schema Related Checks

  • Verify that the enhancement works across all relevant environments (e.g., different OS versions).
  • Link to the relevant Kibana PR or issue provided
  • Test export/import flow:
    • Exported detection rule(s) from Kibana to showcase the feature(s)
    • Converted the exported ndjson file(s) to toml in the detection-rules repo
    • Re-exported the toml rule(s) to ndjson and re-imported into Kibana
  • Updated necessary unit tests to accommodate the feature
  • Incorporated a comprehensive test rule in unit tests for full schema coverage
  • Applied min_compat restrictions to limit the feature to a specified minimum stack version
  • Executed all unit tests locally with a test toml rule to confirm passing
  • Included Kibana PR implementer as an optional reviewer for insights on the feature
  • Implemented requisite downgrade functionality
  • Cross-referenced the feature with product documentation for consistency
  • Confirm that the proper version label is applied to the PR patch, minor, major.

Copy link
Contributor

@eric-forte-elastic eric-forte-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍 🚢

Copy link
Contributor

@Mikaayenson Mikaayenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the others.

@terrancedejesus terrancedejesus merged commit d74c831 into main Mar 13, 2026
16 checks passed
@terrancedejesus terrancedejesus deleted the ignore-ai-artifacts branch March 13, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport: auto maintenance Internal changes patch python Internal python for the repository schema

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants