Add Entity related integrations ML rules with _ea job IDs and min_stack_version 9.4.0#5909
Conversation
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
|
I have take time to review this PR and the upstream integration changes. Below are my observations / concerns
I would recommend if we are not min-stacking the integration, let us also not minstack the rule, this will allow the new job-ids to be back-ported to older stack versions as well and the users if they choose to update the integration will have the right job ID's. Also am not sure why the rules were min-stacked originally but this will cause issues to users on older stack as they can upgrade the integrations. |
|
@susan-shu-c I have pulled in the latest manifest and schemas of the changed ML integrations and the Unit Tests are now passing on the PR. Please note this PR will be merged once we have the prep for release complete and 9.4 branch is available on Wednesday! The PR may see some conflicts as we prepare manifests for other packages, I will take care of that and merge once ready!. |
Pull Request
Issue link(s):
Related to:
_eaML job ID and update minimum stack versions #5794Summary - What I changed
Update DED, DGA, LMD, PAD, and ProblemChild integration ML rules to use the new _ea ML job ID suffix and min_stack_version = "9.4.0". Corresponds to integrations#17626
How To Test
Checklist
bug,enhancement,schema,maintenance,Rule: New,Rule: Deprecation,Rule: Tuning,Hunt: New, orHunt: Tuningso guidelines can be generatedmeta:rapid-mergelabel if planning to merge within 24 hoursContributor checklist