[Rule Tuning] Add windows integration index to rules #923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brokensound77
added
Rule: Tuning
bm11100
approved these changes
Jan 28, 2021
Contributor
bm11100
left a comment
bm11100
left a comment
There was a problem hiding this comment.
LGTM. We'll have to keep an eye on the open PR's not currently in main to make sure some don't slip through without the updated indices.
Samirbous
approved these changes
Jan 28, 2021
…dows-index # Conflicts: # rules/cross-platform/impact_hosts_file_modified.toml # rules/windows/collection_winrar_encryption.toml # rules/windows/command_and_control_remote_file_copy_powershell.toml # rules/windows/credential_access_domain_backup_dpapi_private_keys.toml # rules/windows/defense_evasion_adding_the_hidden_file_attribute_with_via_attribexe.toml # rules/windows/defense_evasion_cve_2020_0601.toml # rules/windows/defense_evasion_delete_volume_usn_journal_with_fsutil.toml # rules/windows/defense_evasion_deleting_backup_catalogs_with_wbadmin.toml # rules/windows/defense_evasion_disable_windows_firewall_rules_with_netsh.toml # rules/windows/defense_evasion_enable_inbound_rdp_with_netsh.toml # rules/windows/defense_evasion_execution_msbuild_started_by_office_app.toml # rules/windows/defense_evasion_execution_msbuild_started_by_script.toml # rules/windows/defense_evasion_execution_msbuild_started_by_system_process.toml # rules/windows/defense_evasion_execution_msbuild_started_unusal_process.toml # rules/windows/defense_evasion_execution_via_trusted_developer_utilities.toml # rules/windows/defense_evasion_installutil_beacon.toml # rules/windows/defense_evasion_misc_lolbin_connecting_to_the_internet.toml # rules/windows/defense_evasion_modification_of_boot_config.toml # rules/windows/defense_evasion_msbuild_making_network_connections.toml # rules/windows/defense_evasion_mshta_beacon.toml # rules/windows/defense_evasion_mshta_making_network_connections.toml # rules/windows/defense_evasion_msxsl_network.toml # rules/windows/defense_evasion_port_forwarding_added_registry.toml # rules/windows/defense_evasion_reg_beacon.toml # rules/windows/defense_evasion_rundll32_no_arguments.toml # rules/windows/defense_evasion_scheduledjobs_at_protocol_enabled.toml # rules/windows/defense_evasion_sdelete_like_filename_rename.toml # rules/windows/defense_evasion_solarwinds_backdoor_service_disabled_via_registry.toml # rules/windows/defense_evasion_unusual_network_connection_via_rundll32.toml # rules/windows/defense_evasion_unusual_process_network_connection.toml # rules/windows/defense_evasion_volume_shadow_copy_deletion_via_wmic.toml # rules/windows/execution_command_shell_started_by_powershell.toml # rules/windows/execution_command_shell_via_rundll32.toml # rules/windows/execution_downloaded_shortcut_files.toml # rules/windows/execution_downloaded_url_file.toml # rules/windows/execution_html_help_executable_program_connecting_to_the_internet.toml # rules/windows/execution_ms_office_written_file.toml # rules/windows/execution_pdf_written_file.toml # rules/windows/execution_psexec_lateral_movement_command.toml # rules/windows/execution_register_server_program_connecting_to_the_internet.toml # rules/windows/execution_scheduled_task_powershell_source.toml # rules/windows/execution_suspicious_cmd_wmi.toml # rules/windows/execution_suspicious_ms_outlook_child_process.toml # rules/windows/execution_suspicious_powershell_imgload.toml # rules/windows/execution_suspicious_psexesvc.toml # rules/windows/execution_via_compiled_html_file.toml # rules/windows/execution_via_net_com_assemblies.toml # rules/windows/impact_volume_shadow_copy_deletion_via_vssadmin.toml # rules/windows/initial_access_script_executing_powershell.toml # rules/windows/initial_access_scripts_process_started_via_wmi.toml # rules/windows/initial_access_suspicious_ms_office_child_process.toml # rules/windows/initial_access_unusual_dns_service_children.toml # rules/windows/initial_access_unusual_dns_service_file_writes.toml # rules/windows/initial_access_via_explorer_suspicious_child_parent_args.toml # rules/windows/lateral_movement_cmd_service.toml # rules/windows/lateral_movement_execution_via_file_shares_sequence.toml # rules/windows/lateral_movement_incoming_wmi.toml # rules/windows/lateral_movement_local_service_commands.toml # rules/windows/lateral_movement_mount_hidden_or_webdav_share_net.toml # rules/windows/lateral_movement_remote_file_copy_hidden_share.toml # rules/windows/lateral_movement_remote_services.toml # rules/windows/lateral_movement_via_startup_folder_rdp_smb.toml # rules/windows/persistence_adobe_hijack_persistence.toml # rules/windows/persistence_app_compat_shim.toml # rules/windows/persistence_appcertdlls_registry.toml # rules/windows/persistence_appinitdlls_registry.toml # rules/windows/persistence_evasion_registry_ifeo_injection.toml # rules/windows/persistence_gpo_schtask_service_creation.toml # rules/windows/persistence_priv_escalation_via_accessibility_features.toml # rules/windows/persistence_registry_uncommon.toml # rules/windows/persistence_run_key_and_startup_broad.toml # rules/windows/persistence_runtime_run_key_startup_susp_procs.toml # rules/windows/persistence_services_registry.toml # rules/windows/persistence_startup_folder_file_written_by_suspicious_process.toml # rules/windows/persistence_startup_folder_scripts.toml # rules/windows/persistence_suspicious_com_hijack_registry.toml # rules/windows/persistence_suspicious_service_created_registry.toml # rules/windows/persistence_system_shells_via_services.toml # rules/windows/persistence_via_application_shimming.toml # rules/windows/persistence_via_hidden_run_key_valuename.toml # rules/windows/persistence_via_lsa_security_support_provider_registry.toml # rules/windows/persistence_via_update_orchestrator_service_hijack.toml # rules/windows/privilege_escalation_uac_bypass_com_clipup.toml # rules/windows/privilege_escalation_uac_bypass_com_ieinstal.toml # rules/windows/privilege_escalation_uac_bypass_com_interface_icmluautil.toml # rules/windows/privilege_escalation_uac_bypass_diskcleanup_hijack.toml # rules/windows/privilege_escalation_uac_bypass_dll_sideloading.toml # rules/windows/privilege_escalation_uac_bypass_event_viewer.toml # rules/windows/privilege_escalation_uac_bypass_mock_windir.toml # rules/windows/privilege_escalation_uac_bypass_winfw_mmc_hijack.toml # rules/windows/privilege_escalation_uac_sdclt.toml # rules/windows/privilege_escalation_unusual_parentchild_relationship.toml # rules/windows/privilege_escalation_unusual_svchost_childproc_childless.toml
brokensound77
commented
Jan 29, 2021
Contributor
Author
Great point - I considered adding a test to ensure both populate, but instead, we'll just need to pay attention and maybe do another review of windows rules once we cut the 7.12 branch |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Related to #255
Summary
Adds the
Windowsintegration indexlogs-windows.*to all rules which currently hadwinlogbeat-*as an index.