Skip to content

Add in-progress preview comment to deploy workflow#27

Merged
Mpdreamz merged 1 commit intomainfrom
feature/comment-in-progress
Mar 25, 2026
Merged

Add in-progress preview comment to deploy workflow#27
Mpdreamz merged 1 commit intomainfrom
feature/comment-in-progress

Conversation

@Mpdreamz
Copy link
Member

Summary

  • Adds a pre-comment job to docs-deploy.yml that runs in parallel with build (right after preflight) to update the PR preview comment with an in-progress indicator and a link to the workflow run. Since phase II triggers on workflow_run and isn't visible as a PR check, this gives reviewers immediate feedback that a preview build/deploy is underway.
  • The final comment job now depends on pre-comment to prevent race conditions when finding/creating the comment.
  • Adds # language= markers to inline scripts for better syntax highlighting in IDEs.

Test plan

  • Open a PR in docs-eng-playground that triggers a docs build and verify the preview comment updates to show "Building and deploying preview..." with a link to the workflow run
  • Verify the comment is then overwritten with actual preview links once the deploy completes
  • Verify that disabling comments (disable-comments: true) skips both pre-comment and comment

Made with Cursor

Phase II (docs-deploy) runs on workflow_run and isn't visible as a PR
check, making it hard to tell when a preview is being built. This adds
a pre-comment job that updates the preview comment to show an
in-progress indicator immediately after preflight, running in parallel
with the build. The final comment job depends on pre-comment to avoid
race conditions.

Also adds # language= markers to inline scripts for better IDE support.

Made-with: Cursor
@Mpdreamz Mpdreamz requested a review from reakaleek March 25, 2026 13:05
@Mpdreamz Mpdreamz added the enhancement New feature or request label Mar 25, 2026
@Mpdreamz Mpdreamz merged commit f31b047 into main Mar 25, 2026
2 of 3 checks passed
@Mpdreamz Mpdreamz deleted the feature/comment-in-progress branch March 25, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants