Fix reusable workflow permissions and make vale-report self-contained#28
Merged
Fix reusable workflow permissions and make vale-report self-contained#28
Conversation
Make the vale-report job in docs-deploy.yml run vale directly instead of downloading artifacts from the phase 1 build workflow, avoiding "no artifacts found" failures. Made-with: Cursor
Mpdreamz
force-pushed
the
feature/fix-permissions
branch
from
535bf34 to
b9ac695
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkjobpull-requests: readpermissions so callers that only grantcontents: readno longer hit a startup failure (failing run).vale-reportself-contained — checkout, get changed files, runelastic/vale-rules/lint, then report — instead of downloading artifacts from the phase 1 build, which caused "no artifacts found" failures (failing run).enable-vale-lintinginput description to remove stale "Phase 1 must also enable" note.Test plan
contents: read(e.g. docs-content) — should no longer fail at startupenable-vale-linting: true— vale-report should run successfully without relying on phase 1 artifactsMade with Cursor