Remove vale linting from deploy workflow for security#36
Merged
Conversation
The vale-report job in docs-deploy.yml checked out and linted fork code in a workflow with elevated permissions (pull-requests: write, id-token, deployments). This is a security risk — the lint step should only run in the unprivileged docs-build.yml workflow. The report action already downloads the vale-results artifact from the build workflow run internally, so the deploy workflow only needs to post the comment. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
reakaleek
force-pushed
the
respected-huckleberry
branch
from
bde5548 to
1a9a947
Compare
The report action uses dawidd6/action-download-artifact to download the vale-results artifact from the triggering workflow run, which requires the actions: read permission to call the workflow runs API. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
Mpdreamz
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vale-reportjob indocs-deploy.yml— these ran fork code in a workflow with elevated permissions (pull-requests: write,id-token,deployments)vale-reportjob now only runselastic/vale-rules/report@main, which downloads thevale-resultsartifact produced bydocs-build.ymland posts a PR commentcontents: read→contents: none) and removes the unusedinclude-pathsinputTest plan
enable-vale-linting: truestill gets a vale report comment (artifact flows from build → deploy)vale-resultsartifact is uploaded by thedocs-build.ymlvale job (default behavior ofelastic/vale-rules/lint)🤖 Generated with Claude Code