Skip to content

Add CF repos to UpdateCLI action #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 30, 2025
Merged

Add CF repos to UpdateCLI action #2103

merged 7 commits into from
Oct 30, 2025

Conversation

@theletterf
Copy link
Contributor

@theletterf theletterf commented Oct 23, 2025

This adds the Cloud Forwarder repos for AWS and Azure to the UpdateCLI configuration, so we can keep those versions updated.

@theletterf theletterf self-assigned this Oct 23, 2025
@theletterf theletterf requested a review from a team as a code owner October 23, 2025 13:59
@theletterf theletterf requested a review from Mpdreamz October 23, 2025 13:59
@theletterf theletterf requested a review from v1v October 23, 2025 13:59
@theletterf
Copy link
Contributor Author

theletterf commented Oct 23, 2025

@v1v Would this be the right config?

v1v
v1v reviewed Oct 23, 2025
View reviewed changes
v1v
v1v approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however wait for IT to onboard the new repository

@theletterf theletterf marked this pull request as draft October 23, 2025 15:08
@theletterf theletterf marked this pull request as ready for review October 30, 2025 07:44
@theletterf theletterf requested a review from a team as a code owner October 30, 2025 07:44
@theletterf
Copy link
Contributor Author

theletterf commented Oct 30, 2025

Agreed with @constanca-m to comment out GCP's blocks for now until a release happens (mid-December).

@theletterf theletterf marked this pull request as draft October 30, 2025 07:47
@theletterf
Copy link
Contributor Author

theletterf commented Oct 30, 2025

@v1v I guess IT's ticket's still not complete?

---------------------------------
ERROR: 	Could not resolve to a Repository with the name 'elastic/edot-cloud-forwarder-aws'.
ERROR: ✗ Could not resolve to a Repository with the name 'elastic/edot-cloud-forwarder-aws'.

@v1v
Copy link
Member

v1v commented Oct 30, 2025 •
edited
Loading

it is resolved and actually I can see it's listed as one of the repositories that our GH app ahs been installed.

You likely need to modify the GitHub action create-token to include the repository too

@theletterf theletterf marked this pull request as ready for review October 30, 2025 08:51
@theletterf
Copy link
Contributor Author

theletterf commented Oct 30, 2025

Ready to go :)

@theletterf theletterf enabled auto-merge (squash) October 30, 2025 08:52
@theletterf theletterf merged commit de70998 into main Oct 30, 2025
23 checks passed
@theletterf theletterf deleted the update-cli-add-cf-repos branch October 30, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reakaleek reakaleek reakaleek approved these changes

@Mpdreamz Mpdreamz Awaiting requested review from Mpdreamz Mpdreamz is a code owner automatically assigned from elastic/docs-engineering

+2 more reviewers

@v1v v1v v1v approved these changes

@constanca-m constanca-m constanca-m left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@theletterf theletterf

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@theletterf @v1v @reakaleek @constanca-m