Skip to content

Remove pre-release tags and build metadata from service.version #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2025
Merged

Remove pre-release tags and build metadata from service.version #2274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/api/Elastic.Documentation.Api.Infrastructure/OpenTelemetry/OpenTelemetryExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,18 @@ private static void ConfigureServiceVersionAttributes<TBuilder>(TBuilder builder
where TBuilder : IHostApplicationBuilder
{

var serviceVersion = Assembly.GetExecutingAssembly()
var informationalVersion = Assembly.GetExecutingAssembly()
.GetCustomAttribute<AssemblyInformationalVersionAttribute>()?.InformationalVersion;

if (serviceVersion is null)
if (informationalVersion is null)
{
Console.WriteLine($"Unable to determine service.version from {nameof(AssemblyInformationalVersionAttribute)}. Skipping setting it.");
return;
}

// Extract just major.minor.patch by removing prerelease tags (-) and build metadata (+)
var serviceVersion = informationalVersion.Split(['+', '-'])[0];

var versionAttribute = new KeyValuePair<string, object>("service.version", serviceVersion);

_ = builder.Services.ConfigureOpenTelemetryTracerProvider(tracerProviderBuilder =>
Expand Down
Loading