Conversation
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While testing #2773 I discovered that the
bundle.resolvein the changelog configuration file was overruling thedocs-builder changelog bundlecommand option--no-resolve.This PR fixes that behaviour so that the command options have precedence over the config options.
Steps to test
I tested this PR against files in elastic/kibana#250840
bundle.resolvesetting. For example:--no-resolveoption. For example:Before this PR, the command-line option was ignored and the bundle was created with resolved details, for example:
With this PR fix, the command line option is heeded. For example:
Implemention details
src/services/Elastic.Changelog/Bundling/ChangelogBundlingService.csBundleChangelogsArguments.Resolve:bool→bool?sonull(unspecified),true(--resolve), andfalse(--no-resolve) are all distinguishable.ApplyConfigDefaults:input.Resolve || config.Bundle.Resolve→input.Resolve ?? config.Bundle.Resolve— uses??so an explicitfalsefrom the CLI is never overridden by the config.BuildBundlecall site:input.Resolve→input.Resolve ?? false— safe fallback when no config and no CLI flag.src/tooling/docs-builder/Commands/ChangelogCommand.csResolve = shouldResolve ?? false→Resolve = shouldResolve— preservesnull(unspecified) soApplyConfigDefaultscan apply the config value when the user doesn't pass either--resolveor--no-resolve.tests/Elastic.Changelog.Tests/Changelogs/BundleChangelogsTests.csBundleChangelogs_WithExplicitResolveFalse_OverridesConfigResolveTrue: setsresolve: truein config, passesResolve = falseto the service, and asserts the bundle contains only a file reference (not inlined content).Generative AI disclosure
Tool(s) and model(s) used: composer-1.5, claude-4.6-sonnet-medium