Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR restructures changelog documentation into focused pages: adds docs/contribute/{configure-changelogs.md,create-changelogs.md,bundle-changelogs.md,publish-changelogs.md}, trims docs/contribute/changelog.md to an overview, and updates docs/_docset.yml TOC to nest these pages. CLI and syntax docs update cross-references to the new pages. docs/cli changelog guides and changelog.example.yml comments receive link and guidance adjustments. Two C# diagnostics (in ChangelogBundlingService.cs and ChangelogConfigurationLoader.cs) update their documentation URLs to the new GitHub docs-builder locations. No functional code changes. 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@src/services/Elastic.Changelog/Configuration/ChangelogConfigurationLoader.cs`:
- Line 871: Replace the inconsistent docs URL string in
ChangelogConfigurationLoader (the line that currently references
"https://elastic.github.io/docs-builder/contribute/configure-changelogs/#bundle-rule-modes")
with the repository-style URL used elsewhere in this file—use
"https://github.com/elastic/docs-builder/blob/main/docs/contribute/configure-changelogs.md#bundle-rule-modes"
so it matches the other updated links (look for the surrounding code in
ChangelogConfigurationLoader where similar docs links appear around lines 805
and 820).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ed84b162-d3fb-4bb9-9018-649d77ca153c
📒 Files selected for processing (16)
config/changelog.example.ymldocs/_docset.ymldocs/cli/changelog/add.mddocs/cli/changelog/bundle-amend.mddocs/cli/changelog/bundle.mddocs/cli/changelog/gh-release.mddocs/cli/changelog/remove.mddocs/cli/changelog/render.mddocs/contribute/bundle-changelogs.mddocs/contribute/changelog.mddocs/contribute/configure-changelogs.mddocs/contribute/create-changelogs.mddocs/contribute/publish-changelogs.mddocs/syntax/changelog.mdsrc/services/Elastic.Changelog/Bundling/ChangelogBundlingService.cssrc/services/Elastic.Changelog/Configuration/ChangelogConfigurationLoader.cs
src/services/Elastic.Changelog/Configuration/ChangelogConfigurationLoader.cs
Outdated
Show resolved
Hide resolved
…ationLoader.cs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
1 participant
This PR is the first step in #3050.
It splits https://docs-v3-preview.elastic.dev/elastic/docs-builder/tree/main/contribute/changelog into subpages so it's not so overwhelming. Each subpage will be edited in subsequent PRs.