Skip to content

Allow .plan extension for assembler deploy apply#3267

Merged
Mpdreamz merged 1 commit into
mainfrom
fix/deploy-apply-plan-extension
May 7, 2026
Merged

Allow .plan extension for assembler deploy apply#3267
Mpdreamz merged 1 commit into
mainfrom
fix/deploy-apply-plan-extension

Conversation

@Mpdreamz
Copy link
Copy Markdown
Member

@Mpdreamz Mpdreamz commented May 7, 2026

Why

The assembler deploy plan command writes plan files with a .plan extension, but assembler deploy apply --plan-file only accepted .json. This caused CI to fail with: extension must be one of: json.

What

Added plan to the allowed extensions on the --plan-file parameter of assembler deploy apply.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@Mpdreamz Mpdreamz requested a review from a team as a code owner May 7, 2026 10:59
@Mpdreamz Mpdreamz added the bug label May 7, 2026
@Mpdreamz Mpdreamz requested a review from cotti May 7, 2026 10:59
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e51ef64e-c4ab-477d-b84d-0074c8b4acf8

📥 Commits

Reviewing files that changed from the base of the PR and between 677e173 and 3125d9c.

📒 Files selected for processing (1)
  • src/tooling/docs-builder/Commands/Assembler/DeployCommands.cs

📝 Walkthrough

Walkthrough

The PR updates the Apply command in DeployCommands.cs to accept both .json and .plan file extensions for the planFile parameter. Previously, only .json files were allowed. The change modifies the FileExtensions attribute validation on line 54 from Extensions = "json" to Extensions = "json,plan", allowing the deployment workflow to process both file types. No other deployment logic or command behavior was altered.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: allowing .plan file extension for the assembler deploy apply command.
Description check ✅ Passed The description provides relevant context explaining why the change was needed (CI failure due to extension mismatch) and what was changed (added plan extension).
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/deploy-apply-plan-extension

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Mpdreamz Mpdreamz merged commit def7daf into main May 7, 2026
25 checks passed
@Mpdreamz Mpdreamz deleted the fix/deploy-apply-plan-extension branch May 7, 2026 11:22
Mpdreamz added a commit that referenced this pull request May 11, 2026
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant