Skip to content

Revert "Create phantom for WIP ingest-processor"#3325

Merged
Mpdreamz merged 1 commit into
mainfrom
revert-3306-shainaraskas-patch-2
May 18, 2026
Merged

Revert "Create phantom for WIP ingest-processor"#3325
Mpdreamz merged 1 commit into
mainfrom
revert-3306-shainaraskas-patch-2

Conversation

@shainaraskas
Copy link
Copy Markdown
Member

Reverts #3306

This didn't solve the problem I was hoping for it to solve

@shainaraskas shainaraskas requested review from a team as code owners May 15, 2026 17:25
@shainaraskas shainaraskas requested a review from technige May 15, 2026 17:25
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e909ac2d-ade4-4729-9d8a-bc314f593be4

📥 Commits

Reviewing files that changed from the base of the PR and between b7a44d2 and 8d1b8f2.

📒 Files selected for processing (1)
  • config/navigation.yml
💤 Files with no reviewable changes (1)
  • config/navigation.yml

📝 Walkthrough

Walkthrough

This PR removes the elasticsearch://reference/ingest-processor entry from the global phantoms section in the navigation configuration file. This single-line removal alters which documentation TOC containers are treated as phantom sources during site navigation building.

Possibly related PRs

  • elastic/docs-builder#3306: Previously added the elasticsearch://reference/ingest-processor phantom source entry that this PR removes.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the changeset: it's a revert of a previous commit that created a phantom entry, matching the removal of the elasticsearch://reference/ingest-processor item from navigation configuration.
Description check ✅ Passed The description is directly related to the changeset, explaining why the revert was made and referencing the original PR being reverted.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch revert-3306-shainaraskas-patch-2

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Mpdreamz Mpdreamz merged commit 26a419f into main May 18, 2026
26 of 27 checks passed
@Mpdreamz Mpdreamz deleted the revert-3306-shainaraskas-patch-2 branch May 18, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants