-
Notifications
You must be signed in to change notification settings - Fork 175
Break up explore-analyze code ownership #3629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+14
−1
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f1ea2c9
break up explore-analyze code ownership for more targeted review requ…
shainaraskas 557219f
Merge branch 'main' into codeowners-refinement
shainaraskas 2a0aa7d
all of the raw files are admin now
shainaraskas 7abf11b
Merge branch 'codeowners-refinement' of github.com:elastic/docs-conte…
shainaraskas 17e3b27
re-add experience as co-owners of some sections
florent-leborgne 4df2306
Merge branch 'main' into codeowners-refinement
shainaraskas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elastic/project-docs looks like we have a missing link here (see the error at the top of this file)
I think we need to add your team as a subteam of docs, but we should do whatever we did for core/exp/dev/admin/ingest - I can't see how they were added, but they weren't given direct permissions to this repo
until we do that, your team won't be notified on the files you've marked as co-owned
cc: @georgewallace we will probably need your help here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be because it's still pending approval to have the "docs" team as its parent. I'll follow up with on who can complete that.