Skip to content

[ECH] Add description of max node count 32 #3686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 30, 2025
Merged

[ECH] Add description of max node count 32 #3686

merged 18 commits into from
Oct 30, 2025

Conversation

@kunisen
Copy link
Contributor

@kunisen kunisen commented Oct 28, 2025 •
edited
Loading

@kunisen kunisen requested a review from eedugon October 28, 2025 05:25
@kunisen kunisen self-assigned this Oct 28, 2025
@kunisen kunisen requested a review from a team as a code owner October 28, 2025 05:25
@github-actions
Copy link

github-actions bot commented Oct 28, 2025 •
edited
Loading

🔍 Preview links for changed docs

jakommo
jakommo approved these changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@jakommo jakommo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. TIL that the API doesn't have this limit 🎉

@kunisen kunisen removed the request for review from eedugon October 29, 2025 01:57
@kunisen
Copy link
Contributor Author

kunisen commented Oct 29, 2025

@jakommo thank you for the review! ❤️

@elastic/admin-docs could you also kindly help review from docs team's perspective please?
I originally added @eedugon as reviewer, but I think probably this could be a more generic topic so I removed the reviewer assignment of Edu, and instead please let me request admin-docs team's help to review 🙏

Thank you!

eedugon
eedugon approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@eedugon eedugon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added small suggestions for capitalization and one sentence structure.

In general this doc would need a review around using lists in some sections directly without any kind of introduction.

For example I don't like much how the node count and size new subsection is presented (directly with a bullets), but taking a look at the rest of the document, the style matches :)

In contrast, the way you have introduced the list in the ech specific limitations subsection looks nicer.

But not a big deal! From content point of view all looks good, not sure if anyone else from @elastic/admin-docs might want to add something else.

kunisen and others added 5 commits October 29, 2025 21:06
@kunisen @eedugon
Update deploy-manage/deploy/elastic-cloud/restrictions-known-problems.md
bad6022 
Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
@kunisen @eedugon
Update deploy-manage/deploy/elastic-cloud/restrictions-known-problems.md
c67ec06 
Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
@kunisen @eedugon
Update deploy-manage/deploy/elastic-cloud/restrictions-known-problems.md
df59b92 
Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
@kunisen @eedugon
Update deploy-manage/autoscaling/autoscaling-in-ece-and-ech.md
c4765da 
Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
@kunisen
Update autoscaling-in-ece-and-ech.md
8bd5dfb
shainaraskas
shainaraskas approved these changes Oct 29, 2025
View reviewed changes
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with edu about the bullets, but we can take that on at a later date. did a little content pass while I was here (sorry for the re-review)

@maggieghamry
Copy link
Contributor

maggieghamry commented Oct 29, 2025

LGTM as well and agreed on the later cleanup, thanks so much @kunisen et al! ⭐

kunisen and others added 6 commits October 30, 2025 09:12
@kunisen @shainaraskas
Update deploy-manage/autoscaling/autoscaling-in-ece-and-ech.md
df27195 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@kunisen @shainaraskas
Update deploy-manage/autoscaling/autoscaling-in-ece-and-ech.md
4b16322 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@kunisen @shainaraskas
Update deploy-manage/autoscaling/autoscaling-in-ece-and-ech.md
2fe1307 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@kunisen @shainaraskas
Update deploy-manage/deploy/elastic-cloud/restrictions-known-problems.md
388dcd0 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@kunisen
please let's keep "in a self-sufficient way" wording
655a31d
@kunisen
Merge branch 'main' into kunisen-docpr-stl-1666
60c06e3
@kunisen kunisen merged commit 2b891b3 into main Oct 30, 2025
7 checks passed
@kunisen kunisen deleted the kunisen-docpr-stl-1666 branch October 30, 2025 00:29
@kunisen
Copy link
Contributor Author

kunisen commented Oct 30, 2025

Thank you all for the kind help and valuable comments! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakommo jakommo jakommo approved these changes

@eedugon eedugon eedugon approved these changes

@shainaraskas shainaraskas shainaraskas approved these changes

Assignees

@kunisen kunisen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kunisen @maggieghamry @jakommo @eedugon @shainaraskas