Skip to content

Conversation

@marciw
Copy link
Contributor

@marciw marciw commented Nov 14, 2025

Fixes #3914

  • Move lifecycle object to the right place in the example
  • Clarify intro text

@marciw marciw requested review from a team as code owners November 14, 2025 22:05
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

🔍 Preview links for changed docs

@marciw marciw requested a review from Copilot November 14, 2025 22:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes formatting issues in the TSDS setup documentation, specifically in the index template configuration section. The changes address GitHub issue #3914 by correcting the structure of the lifecycle configuration object and improving the clarity of the setup instructions.

  • Removed duplicate closing brace from ILM policy example
  • Corrected lifecycle object structure in index template example by moving it to the proper location
  • Refined introductory text for lifecycle management configuration to be clearer

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@marciw marciw requested review from masseyke and pquentin November 14, 2025 22:19
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🦘

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Copy link
Contributor

@georgewallace georgewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. For the call outs they say stack only. (after the examples) we might want to revisit that . is that the right applies to? I know you didn't edit it. But noticed it.

@marciw marciw merged commit 482034e into main Nov 20, 2025
7 checks passed
@marciw marciw deleted the mw-tsds-fix-setup branch November 20, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Internal]: "Set up a TSDS" contains invalid query

5 participants