-
Notifications
You must be signed in to change notification settings - Fork 181
Fix index template step in Set up a TSDS #3945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes formatting issues in the TSDS setup documentation, specifically in the index template configuration section. The changes address GitHub issue #3914 by correcting the structure of the lifecycle configuration object and improving the clarity of the setup instructions.
- Removed duplicate closing brace from ILM policy example
- Corrected lifecycle object structure in index template example by moving it to the proper location
- Refined introductory text for lifecycle management configuration to be clearer
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kilfoyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🦘
pquentin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
georgewallace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. For the call outs they say stack only. (after the examples) we might want to revisit that . is that the right applies to? I know you didn't edit it. But noticed it.
Fixes #3914