-
Notifications
You must be signed in to change notification settings - Fork 185
Dashboards first 20 lines optimization #4084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboards first 20 lines optimization #4084
Conversation
Vale Linting ResultsSummary: 5 suggestions found 💡 Suggestions (5)
|
benironside
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I like this. Most of my suggestions were very minor. After a while I stopped commenting about possibly using attributes in the page description frontmatter, in case it's not applicable. Was this all done by AI or did you participate too?
explore-analyze/dashboards/create-dashboard-of-panels-with-ecommerce-data.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
|
Thanks @benironside - to answer your questions:
|
alaudazzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few suggestions that AI might reconsider :)
|
Noticed a few things were wrong with the privilege terminology - I fixed them here and will fix them in the instructions too. |
|
@alaudazzi can you pls take another look at this |
alaudazzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few more comments.
|
@florent-leborgne I started reviewing, and I can continue tomorrow. 1/ 2/ |
explore-analyze/dashboards/create-dashboard-of-panels-with-ecommerce-data.md
Outdated
Show resolved
Hide resolved
explore-analyze/dashboards/create-dashboard-of-panels-with-ecommerce-data.md
Outdated
Show resolved
Hide resolved
|
@florent-leborgne I scanned through the remaining pages, they look good to me. I haven't tested every single step of the many procedures documented in these pages. Tutorials are OK because they were recently refreshed against the current UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM

Summary
This PR updates the page opening of all Dashboards docs pages. In particular:
These changes follow instructions provided to AI following an onweek project: https://github.com/florent-leborgne/mi-instructions
Generative AI disclosure
Tool(s) and model(s) used: Cursor with Claude Sonnet 4.5